Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linter issues #39

Merged
merged 1 commit into from
Sep 15, 2020
Merged

Fix linter issues #39

merged 1 commit into from
Sep 15, 2020

Conversation

DonJayamanne
Copy link
Contributor

For #28

DonJayamanne
DonJayamanne commented Sep 15, 2020
View reviewed changes
src/client/common/installer/productInstaller.ts
): Promise<InstallerResponse> {
// TODO:
return InstallerResponse.Ignore;
return this.serviceContainer.get<IPythonInstaller>(IPythonInstaller).install(product, resource, cancel);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added missing API.

rchiodo
rchiodo approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these things will be going away with the change I'm working on. Like the jedi changes.

@DonJayamanne
Copy link
Contributor Author

Some of these things will be going away with the change I'm working on. Like the jedi changes.

I hope we do not remove the installer class, as we need that for installation of DS packages.
As for Jedi, dont' care about that stuff.

@rchiodo /cc

@DonJayamanne DonJayamanne merged commit dc4f4d0 into main Sep 15, 2020
@DonJayamanne DonJayamanne deleted the fixLinter28 branch September 15, 2020 19:32
@netocervantes98 netocervantes98 mentioned this pull request Nov 11, 2020
Closed
@ghost ghost mentioned this pull request Nov 11, 2020
Closed
@lifetooeasy lifetooeasy mentioned this pull request Mar 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchiodo rchiodo rchiodo approved these changes

@joyceerhl joyceerhl Awaiting requested review from joyceerhl

@DavidKutu DavidKutu Awaiting requested review from DavidKutu

@IanMatthewHuff IanMatthewHuff Awaiting requested review from IanMatthewHuff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DonJayamanne @IanMatthewHuff @rchiodo